linux: CONFIG_HIDRAW=y #86598
Merged
linux: CONFIG_HIDRAW=y #86598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
approved these changes
May 2, 2020
|
@ofborg build linux_4_4 linux_latest |
lheckemann
approved these changes
May 2, 2020
|
Ah, unsurprisingly this causes a bunch of rebuilds. Should I rebase this against staging instead? |
|
I think the kernel is still fine for master as far as the number of rebuilds is concerned, would defer to someone more knowledgeable though :) |
prusnak
approved these changes
May 2, 2020
|
looks like the build failed for linux_4_4. bummer :( only happened for the arm64 build, the x86 went ok. hum. |
|
This may not be a regression, I'm just building the unmodified arm64 4.4 kernel to compare (and the fact that it wasn't in the cache is a strong suggestion that it's broken anyway). In that case I'd be all for merging this. |
|
Indeed, the build was failing without this change too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The linux kernel arm64 default config doesn't include HIDRAW. The kernel docs list this option as "If unsure, say Y". It's been enabled in x86_64 since 12 years ago. It's also been in OpenWRT for 5 years. I'm not sure why it's not on by default for arm64.
Motivation for this change is feature parity between platforms. I was able to do hidraw input on my desktop and on rpi4 (with rpi kernel), but not an rpi3 with linuxPackages built for aarch64.
That said, I'm not very knowledgeable about kernel modules, and the warning on top of
common-config.nixsounds scary :) so I'd appreciate someone with more experience weighing in if this is as harmless as it looks, or if we should be more careful with the change.I tested this by enabling HIDRAW via kernelPatches, works as expected.
Things done
sandboxinnix.confon non-NixOS linux)