New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/doas: init #86488
Merged
Merged
nixos/doas: init #86488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
labels
May 1, 2020
@ofborg test doas |
emilazy
reviewed
May 2, 2020
@cole-h I took the liberty of getting the version bump on master so the scope of this PR is now only the module. |
adisbladis
changed the title
[WIP] doas: 6.0 -> 6.6.1, nixos/doas: init
[WIP] nixos/doas: init
May 2, 2020
Closed
adisbladis
requested changes
May 2, 2020
adisbladis
reviewed
May 2, 2020
adisbladis
requested changes
May 2, 2020
ofborg
bot
added
8.has: clean-up
10.rebuild-linux: 0
and removed
10.rebuild-linux: 1-10
labels
May 2, 2020
cole-h
commented
May 2, 2020
ofborg
bot
added
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
10.rebuild-linux: 0
labels
May 2, 2020
alyssais
reviewed
May 3, 2020
I now consider this ready! I added a release note at the behest of @adisbladis on IRC -- please let me now if it needs to be moved into some other section (preferably with the location of that section, as well). |
cole-h
force-pushed
the
doas
branch
2 times, most recently
from
May 4, 2020 22:53
701bd99
to
324844e
Compare
`doas` is a lighter alternative to `sudo` that "provide[s] 95% of the features of `sudo` with a fraction of the codebase" [1]. I prefer it to `sudo`, so I figured I would add a NixOS module in order for it to be easier to use. The module is based off of the existing `sudo` module. [1] https://github.com/Duncaen/OpenDoas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I noticed that #74184 was both unmerged and behind by a patch version, so I wanted to update it. Then I read the comment that there was no suid wrapper for it, and thus began my journey into making my very first NixOS module. Most of the work is based off of the existing
sudo
module (including the test).Closes #74184.Version bump was picked into master.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)This is a draft because, although I've tested this in a NixOS VM, I haven't used it for any real length of time. It definitely gets suid and can run commands as root, but that's really the extent of my testing. More testing is welcome, suggestions on what to improve, etc.