sooperlooper: Add alsa library build dependency #86607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, sooperlooper is built without alsa support:
checking alsa/asoundlib.h usability... no
checking alsa/asoundlib.h presence... no
checking for alsa/asoundlib.h... no
This causes sooperlooper to have no midi ports, which prevents it from
being controlled by a hardware midi controller.
This change adds alsaLib as a build dependency. With this change the package
is build with support for alsa midi ports.
This is my very first nixpkgs pull request, if anything is suboptimal I will
happily fix it.
10 tasks
|
While reviewing your PR I noticed the package could be updated and there is another dependency (fftw) missing. I created new PR here: #86610 - can you please review this one whether it works for you? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Currently, sooperlooper is built without alsa support:
This causes sooperlooper to have no midi ports, which prevents it from being controlled by a hardware midi controller.
Things done
This change adds alsaLib as a build dependency. With this change the package is build with support for alsa midi ports.
This is my very first nixpkgs pull request, if anything is suboptimal I will happily fix it. Just give me a note.
I have built and tested the package on nixOS 20.03 without problems. The change should not affect any other package.
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)