Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylibftdi: point to correct libusb library #86602

Merged
merged 2 commits into from May 2, 2020
Merged

Conversation

matthuszagh
Copy link
Contributor

Motivation for this change

@veprbl I missed this issue before. libusb library is libusb-1.0.so. libftdi is fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

httpserver is only used in an example, and prevents python2 builds
from working.
@matthuszagh
Copy link
Contributor Author

I added another commit removing the httpserver dependency. This is only used in an example and prevents pylibftdi from working with python2.

@veprbl veprbl merged commit 434cf0f into NixOS:master May 2, 2020
@matthuszagh matthuszagh deleted the pylibftdi branch May 2, 2020 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants