-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clj-kondo: 2020.04.05 -> 2020.06.12 #86592
Conversation
cecbfb2
to
3211f19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it with graalvm11-ee and looks fine. Good catch with the buildInputs
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/162 |
I could make a PR on this branch for a small graalvm8ce fix actually. I've been last 4 weeks working on graalvm20, it's gonna take few more weeks, and I think the problem preventing a build is very easy problem to solve. |
@hlolli If you have time for that, it would be great. I'm thinking about creating new graalvm packages based on the binaries from https://github.com/graalvm/graalvm-ce-builds, if I find time for it. Of course, your version is preferred, but I'd like to have an alternative version for cases like this, where the build from source is broken for a long period |
@jlesquembre that's exactly what I also have in mind, I want to be able to create an environment where I can develop new graalvm packages using nix. If you're interested, I could take you trough the build process on high level and also get your opinion and suggestions on how to best port graalvm ecosystem over to nix. I feel bit alone with this massive ecosystem. You can check out my open PR #86244 where I've thus far been able to seperate graalpython from the core graalvm. I'm still left with graaljs and fastR. In best case scenario, we'd define a graalvm environment the same way we do in python (using pythonPackages.withPackages [ foo bar];) and develop by converting suite.py to a nix expression, tough that could be a seperate project unrelated to nixpkgs. |
Btw, porting simplelanguage to nixpkgs could be a good "hello world" nixos packaging of graalvm suites. So the question, how would a compilation of somthing like simplelanguage using nix, be best configured. |
@hlolli I took a look to #86244 , but it is massive and I'm lost, I'll need some help to understand what is going on. If I'm not mistaken, what you you want to do is something like graalvm.withLanguages [ llvm python] then you have access to python and llvm to build your graalvm application, is that right? I'm also a bit confused about what you mean by separating graaljs/fastr... from core graalvm, I thought that they were already separated, or at least looks like graalvm project offers different download per component. This conversation is off-topic for this PR, I think we should continue on other place. |
3211f19
to
b81aca5
Compare
New version was released. Bumped PR. |
I will close this. We've updated to graalvm-ce and it doesn't work right now with the latest 2010.10.10 version. I'm upstreaming a change in how the standalone.jar is built that we consume. I will update after the next release. |
Motivation for this change
version bump
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)