Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL2 : Fullscreen to Window #8104

Closed
BeWorld2018 opened this issue May 1, 2020 · 2 comments
Closed

SDL2 : Fullscreen to Window #8104

BeWorld2018 opened this issue May 1, 2020 · 2 comments

Comments

@BeWorld2018
Copy link

Version of OpenTTD

Last version 1.10.1

Steps to reproduce

When OpenTTD opened in fullscreen, when switch to window, impossible to resize window

solution (maybe)

let SDL_WINDOW_RESIZABLE with FULLSCREEN
You can delete condition :
https://github.com/OpenTTD/OpenTTD/blob/master/src/video/sdl2_v.cpp#L265

flags |= SDL_WINDOW_FULLSCREEN | SDL_WINDOW_RESIZABLE;

Thanks
@glx22
Copy link
Contributor

glx22 commented May 1, 2020

Maybe @nikolas can look at it

@nikolas
Copy link
Member

nikolas commented May 28, 2020

Thank you for the report! I will take a look this weekend.

nikolas added a commit to nikolas/OpenTTD that referenced this issue Jun 8, 2020
@nikolas
Fix OpenTTD#8104: always add WINDOW_RESIZABLE flag to SDL2
c174516 
This fixes a bug that can reproduced with these steps:
* Start openttd in fullscreen mode
* Turn off fullscreen mode
* Try to resize the window. The window can't be resized.
freprec pushed a commit to freprec/OpenTTD that referenced this issue Jun 19, 2020
@nikolas @freprec
Fix OpenTTD#8104: Always add WINDOW_RESIZABLE flag to SDL2 (OpenTTD#8211
956e1a1 
)

This fixes a bug that can reproduced with these steps:
* Start openttd in fullscreen mode
* Turn off fullscreen mode
* Try to resize the window. The window can't be resized.
LordAro pushed a commit to LordAro/OpenTTD that referenced this issue Jul 30, 2020
@nikolas @LordAro
Fix OpenTTD#8104: Always add WINDOW_RESIZABLE flag to SDL2 (OpenTTD#8211
e2a2fb8 
)

This fixes a bug that can reproduced with these steps:
* Start openttd in fullscreen mode
* Turn off fullscreen mode
* Try to resize the window. The window can't be resized.
LordAro pushed a commit that referenced this issue Aug 9, 2020
@nikolas @LordAro
Fix #8104: Always add WINDOW_RESIZABLE flag to SDL2 (#8211)
d662e8c 
This fixes a bug that can reproduced with these steps:
* Start openttd in fullscreen mode
* Turn off fullscreen mode
* Try to resize the window. The window can't be resized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nikolas @glx22 @BeWorld2018