fix op_check #1334
Merged
fix op_check #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
approved these changes
May 1, 2020
There was a problem hiding this comment.
without this:
[nix-shell:~/projects/github.com/NixOS/nixops]$ NIX_PATH="nixpkgs=https://nixos.org/channels/nixos-20.03/nixexprs.tar.xz" nixops check --deployment personal
error: Multiple exceptions (5):
* fender: Cannot operate on a closed database.
* flexo: Cannot operate on a closed database.
* kif: Cannot operate on a closed database.
* lord-nibbler: Cannot operate on a closed database.
* ogden: Cannot operate on a closed database.
after:
[nix-shell:~/projects/github.com/NixOS/nixops]$ NIX_PATH="nixpkgs=https://nixos.org/channels/nixos-20.03/nixexprs.tar.xz" nixops check --deploymen
t personal
Machines state:
+--------------+--------+-----+-----------+----------+----------------+----------------------------------------+-------+
| Name | Exists | Up | Reachable | Disks OK | Load avg. | Units | Notes |
+--------------+--------+-----+-----------+----------+----------------+----------------------------------------+-------+
| fender | Yes | No | N/A | N/A | | | |
| flexo | Yes | Yes | Yes | N/A | 0.18 0.25 0.27 | proc-sys-fs-binfmt_misc.mount [failed] | |
| | | | | | | everyaws.service [failed] | |
| kif | Yes | Yes | Yes | N/A | 0.11 0.22 0.26 | proc-sys-fs-binfmt_misc.mount [failed] | |
| lord-nibbler | Yes | Yes | Yes | N/A | 0.00 0.05 0.01 | proc-sys-fs-binfmt_misc.mount [failed] | |
| ogden | Yes | No | N/A | N/A | | | |
+--------------+--------+-----+-----------+----------+----------------+----------------------------------------+-------+
Non machines resources state:
+------+--------+
| Name | Exists |
+------+--------+
+------+--------+
adisbladis
approved these changes
May 1, 2020
|
I won't block on the ratchet, but if anyone wants to add a commit improving type coverage in this file that would be cool :). |
|
@grahamc what is this ratchet thing, and why does it not like the commit? |
|
@manveru It's to force us to increase type coverage over time, so we measure the coverage before and after the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.