Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing logging #480

Merged
merged 10 commits into from May 4, 2020
Merged

tracing logging #480

merged 10 commits into from May 4, 2020

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented May 1, 2020 •
edited

Screenshot 2020-05-01 at 20 30 08

Or with json formatting (not currently enabled yet).

{"timestamp":"May 01 21:37:06.878","level":"INFO","target":"builder","fields":{"message":"Fetching jobs from build-inputs-x86_64-darwin"}}
{"timestamp":"May 01 21:37:06.878","level":"INFO","target":"async_std::task::block_on","fields":{"message":"block_on","log.target":"async_std::task::block_on","log.module_path":"async_std::task::block_on","log.file":"/Users/lnl/.cargo/registry/src/github.com-1ecc6299db9ec823/async-std-1.5.0/src/task/block_on.rs","log.line":45}}
{"timestamp":"May 01 21:37:14.589","level":"DEBUG","target":"ofborg::easylapin","fields":{"message":"consumed delivery","deliver.delivery_tag":"1"}}
{"timestamp":"May 01 21:37:14.590","level":"INFO","target":"ofborg::tasks::build","fields":{"message":"lmao I got a job?"}}
{"timestamp":"May 01 21:37:14.591","level":"INFO","span":{"name":"job","pr":"42"},"target":"ofborg::tasks::build","fields":{"message":"Working on https://github.com/NixOS/ofborg/pull/42"}}
{"timestamp":"May 01 21:37:14.591","level":"INFO","span":{"name":"job","pr":"42"},"target":"ofborg::clone","fields":{"message":"Locking \"/tmp/ofborg/repo/af830982ebfb48a0b27598205be6f7ea/clone.lock\""}}

LnL7 added 3 commits May 1, 2020 19:05
@LnL7
add tracing
ceef89c 
An alternative logging library with support for structured logging as
well as slightly nicer default output.
@LnL7
update carnix
a2e5dad
@LnL7
log -> tracing
35e08cb
cole-h
cole-h reviewed May 1, 2020
View reviewed changes
ofborg/src/tasks/build.rs Outdated Show resolved Hide resolved
@LnL7
silence some clippy warnings
52e2105 
It looks like the current version of rustc/clippy seems the include expanded
macros (like tracing) in the complexity.  None of these warnings show up
with rust 1.42.0.
@LnL7 LnL7 mentioned this pull request May 3, 2020
Merged
LnL7 added 3 commits May 3, 2020 15:14
@LnL7
add json logging
72b41d9
@LnL7
add basic structrue logging to evaluator
c65ec0a
@LnL7
reduce publish logging to trace level
5be617c 
Each log line is pushed to the logs exchange so this is _way_ to verbose
to enable by default.
@cole-h cole-h merged commit 1112e3a into NixOS:released May 4, 2020
@LnL7 LnL7 deleted the tracing branch May 4, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LnL7 @cole-h