Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

genpass: init at 0.4.1 #86504

Merged
merged 2 commits into from May 9, 2020
Merged

genpass: init at 0.4.1 #86504

merged 2 commits into from May 9, 2020

Conversation

cyplo
Copy link
Contributor

@cyplo cyplo commented May 1, 2020

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cole-h
cole-h requested changes May 2, 2020
View reviewed changes
pkgs/tools/security/genpass/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/genpass/default.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
@cyplo
Copy link
Contributor Author

cyplo commented May 2, 2020

thanks so much for a comprehensive review @cole-h !
all should be changed now - if you could take a look ? :)

cole-h
cole-h approved these changes May 2, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. Binary displays help and does indeed generate passwords/phrases.

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/86504
1 package built:
genpass

@cyplo
Copy link
Contributor Author

cyplo commented May 7, 2020 •
edited

heya @cole-h - would you know who best to ping here to get this one merged ? thanks ! :)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/150

@bjornfor bjornfor merged commit 69c6d18 into NixOS:master May 9, 2020
@cyplo cyplo deleted the add-genpass branch May 9, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cyplo @nixos-discourse @bjornfor @cole-h