Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yabai: 2.4.3 -> 3.0.0 #86557

Merged
merged 1 commit into from May 2, 2020
Merged

yabai: 2.4.3 -> 3.0.0 #86557

merged 1 commit into from May 2, 2020

Conversation

cmacrae
Copy link
Contributor

@cmacrae cmacrae commented May 2, 2020

Motivation for this change

A release happened right after my new package for yabai was merged in yesterday.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member

prusnak commented May 2, 2020 •
edited

Please put the URL in the homepage field into quotes (as per RFC45).

@cmacrae
Copy link
Contributor Author

cmacrae commented May 2, 2020

Thanks @prusnak, done :)

@LnL7 LnL7 merged commit 64279cf into NixOS:master May 2, 2020
@cmacrae cmacrae mentioned this pull request May 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cmacrae @prusnak @LnL7