Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skhd: 0.3.0 -> 0.3.5 #86559

Merged
merged 1 commit into from May 2, 2020
Merged

skhd: 0.3.0 -> 0.3.5 #86559

merged 1 commit into from May 2, 2020

Conversation

cmacrae
Copy link
Contributor

@cmacrae cmacrae commented May 2, 2020

Motivation for this change

Just a simple upgrade.
@LnL7 @periklis hope you don't mind that I've added myself as a maintainer on this package :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented May 2, 2020

@GrahamcOfBorg build skhd

Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LnL7 LnL7 merged commit fb9831c into NixOS:master May 2, 2020
@cmacrae
Copy link
Contributor Author

cmacrae commented May 2, 2020

Thanks for the quick review and merge 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants