b4: init at 0.4.0 #86558
Closed
b4: init at 0.4.0 #86558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
jonringer
reviewed
May 3, 2020
pkgs/top-level/python-packages.nix
Outdated
| @@ -490,6 +490,8 @@ in { | |||
|
|
|||
| azure-multiapi-storage = callPackage ../development/python-modules/azure-multiapi-storage { }; | |||
|
|
|||
| b4 = callPackage ../applications/version-management/git-and-tools/b4 { }; | |||
There was a problem hiding this comment.
python-modules shouldn't contain a buildPythonApplication. The package won't appear to downstream dependencies.
If you want to package this a python module, please use buildPythonPackage or pythonXPackages.toPythonModule
There was a problem hiding this comment.
It is a application though, a commandline utility.
There was a problem hiding this comment.
buildPythonPackage will still show entry points as command line utilities, the difference is in downstream dependencies. Please read https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#building-packages-and-applications
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)