Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] keybase,kbfs,keybase-gui: 5.0.0 -> 5.4.2 #86604

Merged

Conversation

fabianhjr
Copy link
Member

@fabianhjr fabianhjr commented May 2, 2020

Motivation for this change

Keybase has shipped many bugfixes and an essential features (blocking other people) since this is a security focused tool backporting this version upgrades from nixpkgs/master would be desirable.

Bufixes of features available on 5.0.0 from upstream:

5.1.0:

  • Various bug fixes around team management
  • Dark mode fixes
  • Smaller bug fixes and performance improvements

5.1.1:

  • This is a bugfix release.
  • Enabled blocking users from their profile

5.2.0:

  • Various bug fixes and performance improvements.

5.2.1:

  • This is a bugfix release.

5.3.0:

  • Many performance improvements and bug fixes

5.3.1:

  • This is a bugfix release.

5.4.0:
n/a (only feature additions and fixes of feature additions after 5.0.0)

5.4.1:

  • Fix KBFS performance issues

5.4.2:

  • This is a bugfix release for KBFS performance.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Br1ght0ne and others added 8 commits May 2, 2020 12:39
(cherry picked from commit a665c1e0c87a1dd97c12940cad9d659b9e22bcd7)
(cherry picked from commit 0c65f3f0d78b2d91df0e2a6819a7f9ce6780549e)
(cherry picked from commit ee2faf31e55cab1192fc57876dff6dce6d561bc3)
(cherry picked from commit 0dbccd06cab066f8e5094b3ed53910e234fff891)
(cherry picked from commit d47ddc636b134e4070b0c7cbee6a879bb7992005)
(cherry picked from commit 3f8e7741cf723b36a278750614036bebbd74e9c6)
(cherry picked from commit e1820dc344d36c27b3b8a81fbd3274d50041cb66)
(cherry picked from commit 0a7e9c3d5d9082a0f1d153f4f4b1d912429aef10)
@Avaq
Copy link
Member

Avaq commented May 2, 2020

I just built this on nixos with sandboxing and verified that kbfs, keybase, keybase-gui and the keybase daemon are working as expected.

@bhipple
Copy link
Contributor

bhipple commented May 3, 2020

Result of nixpkgs-review pr 86604 1

3 packages built:
- kbfs
- keybase
- keybase-gui

@bhipple bhipple merged commit c0137eb into NixOS:release-20.03 May 3, 2020
@drewrisinger drewrisinger mentioned this pull request May 3, 2020
10 tasks
@fabianhjr fabianhjr deleted the backport-keybase-upgrades branch November 1, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants