Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

>=2 objects in eq and parallel constraints #530

Closed
wants to merge 1 commit into from
Closed

>=2 objects in eq and parallel constraints #530

wants to merge 1 commit into from

Conversation

77maxikov
Copy link
Contributor

No description provided.

@Timmmm Timmmm mentioned this pull request Mar 29, 2020
Closed
whitequark
whitequark suggested changes May 2, 2020
View reviewed changes
Copy link
Contributor

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR implements the feature in an ad-hoc and invasive way; I find it hard to convince myself that every added code path is correct. It doesn't follow our code style either.

@whitequark
Copy link
Contributor

@phkahler I'm tempted to avoid changing the way we handle adding constraints until we do something to solve #121 properly, which requires even more infrastructural work. (Unfortunately #492 has problems similar to the problems with this PR.)

@phkahler phkahler force-pushed the master branch 2 times, most recently from dfb96de to 3f09eaf Compare November 7, 2020 20:39
@ruevs ruevs mentioned this pull request Dec 2, 2020
Closed
@ruevs ruevs mentioned this pull request Feb 3, 2021
Closed
@ruevs ruevs mentioned this pull request Apr 22, 2021
Open
17 tasks
@ruevs ruevs linked an issue Jan 8, 2022 that may be closed by this pull request
Allow constraints to apply to multiple objects #573
Closed
@ruevs ruevs mentioned this pull request Jul 9, 2022
Merged
@ruevs ruevs marked this pull request as draft July 11, 2022 23:01
@phkahler
Copy link
Member

After looking at this problem a lot, I believe this is the way. @77maxikov if you rebase this to master I'll merge it and then build on it a little. I'll probably do it myself this weekend if nobody else does - I'm getting the itch to work on solvespace again!

@77maxikov
Copy link
Contributor Author

#1314

@phkahler
Copy link
Member

Closing since 1314 was used.

@phkahler phkahler closed this Dec 31, 2022
@ruevs ruevs mentioned this pull request Jan 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow constraints to apply to multiple objects
3 participants
@77maxikov @whitequark @phkahler