Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sooperlooper: unstable-2016-07-19 -> unstable-2019-09-30 #86610

Merged
merged 1 commit into from May 10, 2020
Merged

sooperlooper: unstable-2016-07-19 -> unstable-2019-09-30 #86610

merged 1 commit into from May 10, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented May 2, 2020 •
edited

Motivation for this change

Version update + added alsaLib and fftw dependencies

Supersedes #86607

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak mentioned this pull request May 2, 2020
Closed
8 tasks
@prusnak
Copy link
Member Author

prusnak commented May 2, 2020

@kasimon can you please review whether this works for you?

@prusnak prusnak requested a review from magnetophon May 2, 2020 19:47
@kasimon
Copy link
Contributor

kasimon commented May 3, 2020

@prusnak I have built and tested your change and as far as I can tell it works great. Thank you for taking care of the issue so fast!

magnetophon
magnetophon approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@magnetophon magnetophon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmahut mmahut merged commit 3b039f1 into NixOS:master May 10, 2020
@prusnak prusnak deleted the sooperlooper branch May 10, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnetophon magnetophon magnetophon approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prusnak @kasimon @magnetophon @mmahut