php.buildPecl: Make it possible for PECLs to depend on other PECLs, fix apcu_bc and couchbase #86614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talyz
changed the title
Some PECLs depend on other PECLs and, like internal PHP extension dependencies, need to be loaded in the correct order. This makes this possible by adding the argument "peclDeps" to buildPecl, which adds the extension to buildInputs and is treated the same way as internalDeps when the extension config is generated.
Fix an issue brought up in NixOS#86463, where the apcu_bc extension isn't loaded correctly since it produces a .so with a different name than the extension name. Also, the apcu extension has to be loaded and loaded prior to loading this extension.
The pcs extension fails to load at runtime with PHP 7.3, so let's mark it broken from 7.3 onwards. It also depends on the tokenizer internal extension.
The couchbase extension depends on the igbinary PECL which needs to be loaded and loaded prior to it. It also seems like the pcs extension isn't actually needed - it at least builds and loads without it. Since the pcs extension dependency was the reason couchbase didn't build on PHP 7.4 it now does, so let's unmark it broken.
talyz
force-pushed
the
php-buildpecl-pecldeps
branch
from
0bfb145
to
fa4c995
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Some PECLs depend on other PECLs and, like internal PHP extension dependencies, need to be loaded in the correct order. This makes this possible by adding the argument
peclDepstobuildPecl, which adds the extension tobuildInputsand is treated the same way asinternalDepswhen the extension config is generated.Fix an issue brought up in PHP Module Rdkafka #86463, where the
apcu_bcextension isn't loaded correctly since it produces a.sowith a different name than the extension name. Also, theapcuextension has to be loaded and loaded prior to loading this extension.The
couchbaseextension depends on theigbinaryPECL which needs to be loaded and loaded prior to it. It also seems like thepcsextension isn't actually needed - it at least builds and loads without it. Since thepcsextension dependency was the reasoncouchbasedidn't build onPHP 7.4 it now does. I don't have any couchbase testing setup, though, so I can't verify that the extension really works - if anyone does, help with testing would be greatly appreciated.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)