Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmTools.diskImageFuns.debian9x86_64: update source url #86575

Closed
wants to merge 1 commit into from
Closed

vmTools.diskImageFuns.debian9x86_64: update source url #86575

wants to merge 1 commit into from

Conversation

apeyroux
Copy link
Member

@apeyroux apeyroux commented May 2, 2020

Motivation for this change

Use mirror:// syntax and use a more recent Packages.xz.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@OmnipotentEntity
Copy link
Contributor

OmnipotentEntity commented Aug 12, 2020 •
edited

The change itself seems to be OK. Though I'll be the first to admit that I have only the most basic of understanding of this part of nixpkgs.

However, why wasn't the i386 entry also updated? (For instance, you yourself committed this diff previously.)

SuperSandro2000
SuperSandro2000 requested changes Dec 29, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the debian9i386 url.

@stale
Copy link

stale bot commented Jun 28, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 28, 2021
@sikmir
Copy link
Member

sikmir commented Oct 20, 2022

Already updated on master.

@sikmir sikmir closed this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@OmnipotentEntity OmnipotentEntity Awaiting requested review from OmnipotentEntity

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@apeyroux @OmnipotentEntity @sikmir @SuperSandro2000