Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromedriver: 81.0.4044.69 -> 83.0.4103.39 #88602

Merged
merged 1 commit into from May 23, 2020
Merged

chromedriver: 81.0.4044.69 -> 83.0.4103.39 #88602

merged 1 commit into from May 23, 2020

Conversation

bennyandresen
Copy link
Contributor

Motivation for this change

Version bump, as chromedriver has to be the same major version as chromium

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @cillianderoiste @marsam

das-g
das-g approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@das-g das-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 88602 1

3 packages built:
- chromedriver
- selendroid
- selenium-server-standalone

Smoke test

Smoke-tested as follows:

  1. put the following into ./shell.nix: 
    let
  pkgs = import <nixpkgs> {};
  pypkgs = p: with p; [
    selenium
  ];
  py = pkgs.python3.withPackages pypkgs;
in
pkgs.mkShell {
  buildInputs = with pkgs; [
    py
    chromium
    chromedriver
  ];
}
  2. put the following into ./smoketest.py: 
    from selenium import webdriver

browser = webdriver.Chrome()
browser.get('https://nixos.org')

assert 'NixOS Linux' in browser.title
browser.quit()
  3. run 
    nix-shell -I nixpkgs=~/dev/nixos/nixpkgs --run 'python smoketest.py'
    while 3960e06 is checked out at ~/dev/nixos/nixpkgs.

Observed

  • Chromium pops up and vanishes again
  • return code is 0

@marsam marsam merged commit 6b2cfc7 into NixOS:master May 23, 2020
@bennyandresen bennyandresen deleted the chromedriver_versionbump branch November 12, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@das-g das-g das-g approved these changes

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bennyandresen @das-g @marsam