Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copper: init at 4.4 #88545

Merged
merged 1 commit into from Aug 24, 2020
Merged

copper: init at 4.4 #88545

merged 1 commit into from Aug 24, 2020
+35 −1

Conversation

jacereda
Copy link
Contributor

Motivation for this change

Copper is used to build code-browser: https://tibleiz.net/code-browser/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jacereda jacereda mentioned this pull request May 21, 2020
Merged
10 tasks
@Lassulus
Copy link
Member

needs a rebase

@jacereda
Copy link
Contributor Author

needs a rebase

Done.

@Lassulus
Copy link
Member

running coc or collvm gives me /nix/store/daraq50260yqj003inkgsvyxpfqnf3w6-copper-4.4/bin/coc: line 35: copper-c: command not found. Should this work?

@jacereda
Copy link
Contributor Author

running coc or collvm gives me /nix/store/daraq50260yqj003inkgsvyxpfqnf3w6-copper-4.4/bin/coc: line 35: copper-c: command not found. Should this work?

Those are the scripts for the LLVM and C backends. This package only builds the x64 backend.

@Lassulus
Copy link
Member

Alright, I guess someone can add them later if they are needed

@Lassulus Lassulus merged commit 4f68ebf into NixOS:master Aug 24, 2020
@jacereda
Copy link
Contributor Author

Thanks. If you want to see it in use: #88548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacereda @Lassulus