Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] Update Electron 6,7,8 #88550

Merged
merged 3 commits into from
Jun 1, 2020
Merged

[20.03] Update Electron 6,7,8 #88550

merged 3 commits into from
Jun 1, 2020
+18 −18

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented May 21, 2020 •
edited
Loading

Motivation for this change

Backport of #86237 to stable - contains security fixes (9x CVE)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

prusnak added 3 commits May 21, 2020 23:35
@prusnak
electron_6: 6.1.7 -> 6.1.12

Verified

This commit was signed with the committer’s verified signature.
renovate-bot Mend Renovate
GPG key ID: 81C63AE1C224182B
Verified
Learn about vigilant mode
9a5239f 
(cherry picked from commit 77cade8)
@prusnak
electron_7: 7.1.10 -> 7.3.0
b3c5bba 
(cherry picked from commit eee7e5b)
@prusnak
electron_8: 8.0.0 -> 8.3.0
a99bb40 
(cherry picked from commit 72aebd3)
@prusnak prusnak added the 8.has: port to stable A PR already has a backport to the stable release. label May 21, 2020
@prusnak prusnak mentioned this pull request May 21, 2020
Merged
10 tasks
@veprbl veprbl added the 1.severity: security Issues which raise a security issue, or PRs that fix one label May 23, 2020
@mmahut mmahut requested review from travisbhartwell and manveru May 24, 2020 11:57
@mmahut mmahut merged commit 4a2da01 into NixOS:release-20.03 Jun 1, 2020
@prusnak prusnak deleted the electron-20.03 branch June 1, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisbhartwell travisbhartwell

@manveru manveru

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @mmahut @veprbl