Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openafs_1_8: include 5.6 fixes #88552

Merged
merged 1 commit into from
May 23, 2020
Merged

openafs_1_8: include 5.6 fixes #88552

merged 1 commit into from
May 23, 2020
+19 −1

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented May 21, 2020 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

This was referenced May 21, 2020
Merged
Merged
@Mic92
Copy link
Member Author

Mic92 commented May 21, 2020

cc @lzmartinico

@Mic92
Copy link
Member Author

Mic92 commented May 21, 2020

@GrahamcOfBorg eval

@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label May 21, 2020
@Mic92
openafs_1_8: include 5.6 fixes

Verified

This commit was signed with the committer’s verified signature. The key has expired.
veehaitch Vincent Haupert
GPG key ID: A8B605E96F82B4E4
Expired
Verified
Learn about vigilant mode
0279083
@Mic92
Copy link
Member Author

Mic92 commented May 21, 2020

@GrahamcOfBorg eval

@ofborg ofborg bot requested review from spacefrogg and maggesi May 21, 2020 22:18
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels May 21, 2020
@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label May 21, 2020
@Mic92
Copy link
Member Author

Mic92 commented May 22, 2020

@andersk please test. I already had the backported tested.

andersk
andersk approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@andersk andersk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@Mic92 Mic92 merged commit b2b31b6 into NixOS:master May 23, 2020
@Mic92 Mic92 deleted the openafs branch May 23, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersk andersk

@spacefrogg spacefrogg

@maggesi maggesi

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @andersk @cole-h