Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] openafs_1_8: include 5.6 fixes #88553

Merged
merged 1 commit into from May 23, 2020
Merged

[backport] openafs_1_8: include 5.6 fixes #88553

merged 1 commit into from May 23, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented May 21, 2020 •
edited

(cherry picked from commit 5fb7ac3d1845c409a7502e73b137092a4c52d330)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented May 21, 2020

Backport of #88552

@Mic92
Copy link
Member Author

Mic92 commented May 21, 2020

cc @lzmartinico

@Mic92
Copy link
Member Author

Mic92 commented May 21, 2020

@GrahamcOfBorg eval

@ofborg ofborg bot requested review from maggesi and spacefrogg May 21, 2020 22:10
@Mic92
openafs_1_8: include 5.6 fixes
ae901c4 
(cherry picked from commit 0279083)
@Mic92
Copy link
Member Author

Mic92 commented May 22, 2020

@lzmartinico tested this backport for me.

spacefrogg
spacefrogg approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@spacefrogg spacefrogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for picking it up!

@roberth roberth added the 8.has: port to stable A PR already has a backport to the stable release. label May 22, 2020
@ofborg ofborg bot requested a review from spacefrogg May 22, 2020 13:54
@Mic92 Mic92 merged commit b5d622a into NixOS:release-20.03 May 23, 2020
@Mic92 Mic92 deleted the openafs-backport branch May 23, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maggesi maggesi Awaiting requested review from maggesi

@spacefrogg spacefrogg Awaiting requested review from spacefrogg

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @spacefrogg @roberth