New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mbed-cli: 1.9.1 -> 1.10.2 #68947
mbed-cli: 1.9.1 -> 1.10.2 #68947
Conversation
89b2194
to
60d6ba2
Compare
@rvolosatovs , is this still WIP? |
Still waiting for #67730 to be merged... |
60d6ba2
to
c352e79
Compare
c352e79
to
58295f4
Compare
pip | ||
pyserial | ||
|
||
# Some of mbed-os dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So basically mbed-cli
tries to run pip
to install project dependencies.
Essentially all projects using this application will have a dependency on mbed-os
, and so the following is a list of most of it's dependencies(https://github.com/ARMmbed/mbed-os/blob/master/requirements.txt) - the rest do not have a Nix package.
Not fancy and will probably break if the mbed-os
dependencies change.
My idea is that users could set up venv
with the missing dependencies and then use the mbed-cli
package with the rest.
Any (simple) idea how to handle this better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for packages that require specific dependencies which don't reflect the current python ecosystem you should do something similar to aws-sam-cli
Two things that are special about it:
- it's not in python-packages, so it can't be imported
- it's only used as an application
If you still need to use the package in python-modules, then you will have issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
however, for the update story, I don't think that would be a supported usecase as it expects to be able to write to site-packages
@GrahamcOfBorg build mbed-cli |
FTR, so far I did not have much success using the Nix package and myself resort to using a Docker image: Ideally I would want to be able to just add the I don't really know how to make it work. |
58295f4
to
d1b9c01
Compare
Closing this, since not clear how to proceed |
this could potentially work with buildFHSUserEnv, but I don't have much experience using that utility |
Motivation for this change
Upstream update
mbed-os-tools
is added as dependency tombed-cli
Replaces #53956
Depends on #67730 (I will remove the [WIP] from the title, once that PR is merged and this one is rebased)Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)