Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zbar: 0.23 -> 0.23.1 #88527

Merged
merged 1 commit into from May 23, 2020
Merged

zbar: 0.23 -> 0.23.1 #88527

merged 1 commit into from May 23, 2020

Conversation

KoviRobi
Copy link
Contributor

@KoviRobi KoviRobi commented May 21, 2020 •
edited

This allows decoding binary QR codes, e.g as in
https://wiki.archlinux.org/index.php/Paperkey

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from delroth and 7c6f434c May 21, 2020 17:52
@7c6f434c
Copy link
Member

Hash change without version update, does not work.

@jtojnar
Copy link
Contributor

jtojnar commented May 23, 2020

Changelog looks okay: https://github.com/mchehab/zbar/blob/0.23.1/ChangeLog#L1-L15

We disable python and explicitly set gtk3 so the autodetect changes should not affect us.

zbar: 0.23 -> 0.23.1
d48ec14 
This allows decoding binary QR codes, e.g as in
https://wiki.archlinux.org/index.php/Paperkey
@KoviRobi
Copy link
Contributor Author

Oh that's my bad, but it turns out just hash update does actually work as fetchgit fetches by hash, today I learnt.

@KoviRobi
Copy link
Contributor Author

I don't have a working webcam on this laptop (no driver, Intel AVStream 2500) but zbarcam-{qt,gtk} at least launch without errors, it's zbarimg that I needed to get updated

@7c6f434c 7c6f434c merged commit 80ab05e into NixOS:master May 23, 2020
@soareschen soareschen mentioned this pull request Jun 1, 2020
Merged
10 tasks
@KoviRobi KoviRobi deleted the zbar-0.23.1-update branch October 10, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delroth delroth Awaiting requested review from delroth

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KoviRobi @7c6f434c @jtojnar