New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/qemu-vm: add option to use qboot #88574
Conversation
@ofborg test simple qboot |
Is it possible for ofborg to run the tests on i386? |
@GrahamcOfBorg build pkgsi686Linux.nixosTests.simple pkgsi686Linux.nixosTests.qboot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't be better to add a bios
option that takes a package or path?
It would be useful when developing a bios.
cda1161
to
12bfe1e
Compare
More a question, less a requirement for this PR to be merged: I ran |
@flokli If you're not aware, that status quo is that only this output (from SeaBIOS) is shown on the display, up until the getty part: The kernel logs all go to the serial console, i.e. the output of nix-build - imo this is probably the most useful place for them to be. |
12bfe1e
to
3c72e00
Compare
Fixed an embarrassing type-system mistake (I forgot to allow null, despite that being the default...) @ofborg test simple qboot |
I'm weirded out by how ofborg didn't error when I tested simple before though :/ |
I'd like to change the default on x86 platforms to qboot at some point, since it saves a fair bit of startup time.
3c72e00
to
55912f3
Compare
Motivation for this change
qboot is a minimal x86 bios for use under QEMU, replacing the default (SeaBIOS).
This provides a 700-800ms improvement to boot times when enabled, so long-term I'd love to turn it on by default (at least for nixos tests).
See the runtimes of a simple "wait for multi-user.target" test, with and without the option enabled:
Desktop, AMD 2600X
Laptop, Intel i5-8250U
Percentage-wise, this becomes much more significant after further changes I'm working on, especially the use of virtiofs instead of 9pfs.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)