Clipboard API Tests: Clarify limitations of user gesture utils. #23739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 22, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2208816
branch
from
d7e092c
to
09cd4cf
Compare
The user gesture utils only work on top-level frames. This is due to its dependencies, and would be surfaced via runtime messages, but I figured this would be good to clarify upfront. Change-Id: Ic4bafc948a2ac1f419a6ca8bd4cc3eb20404553b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208816 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#773461}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2208816
branch
from
09cd4cf
to
40da11b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user gesture utils only work on top-level frames. This is
due to its dependencies, and would be surfaced via runtime
messages, but I figured this would be good to clarify upfront.
Change-Id: Ic4bafc948a2ac1f419a6ca8bd4cc3eb20404553b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208816
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773461}