lapin evaluation filter #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
approved these changes
May 21, 2020
grahamc
reviewed
May 22, 2020
Comment on lines
+52
to
+57
| chan.bind_queue(easyamqp::BindQueueConfig { | ||
| queue: queue_name.clone(), | ||
| exchange: "github-events".to_owned(), | ||
| routing_key: Some("pull_request.nixos/nixpkgs".to_owned()), | ||
| no_wait: false, | ||
| })?; |
There was a problem hiding this comment.
This change is binding mass-rebuild-check-jobs to subscribe directly to github-events, where mass-rebuild-check-inputs should be binding to github-events and then this task writes the filtered tasks to the jobs queue.
There was a problem hiding this comment.
Good catch, sorry I missed that.
There was a problem hiding this comment.
These kind of subtile bugs are also really hard to catch during review if you're not looking for something specific.
|
No worries, it happens to the best of us. Accidents will happen and things will break sometimes. The benefits of this PR and making progress in general far outweigh the risks!
Thank you for the PR and for the review, keep up the good work :)
On Fri, May 22, 2020, at 11:04 AM, Cole Helbling wrote:
***@***.**** commented on this pull request.
In ofborg/src/bin/evaluation-filter.rs <#491 (comment)>:
> + chan.bind_queue(easyamqp::BindQueueConfig {
+ queue: queue_name.clone(),
+ exchange: "github-events".to_owned(),
+ routing_key: Some("pull_request.nixos/nixpkgs".to_owned()),
+ no_wait: false,
+ })?;
…
Good catch, sorry I missed that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#491 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAASXLF27E45HTKR6WGUHNLRS2H7HANCNFSM4NHC67KQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.