Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test both negotiated & non-negotiated datachannels #23737

Merged
merged 3 commits into from May 28, 2020

Conversation

jan-ivar
Copy link
Member

Fixes createDataChannelPair() helper to test both negotiated and non-negotiated datachannels.

cc @alvestrand

@jan-ivar
Copy link
Member Author

The timeout looks unrelated.

Copy link
Contributor

@alvestrand alvestrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since https://wpt.fyi/results/webrtc/RTCDataChannel-close.html?sha=ee3f673ed8&label=pr_head now shows that the timeout hits non-negotiated datachannels only, I'm willing to accept this for expediency (one of my projects is stalled waiting for this fix), but would prefer that the name & indent issues be fixed before submitting.
Approving.

webrtc/RTCDataChannel-bufferedAmount.html Show resolved Hide resolved
webrtc/RTCDataChannel-bufferedAmount.html Outdated Show resolved Hide resolved
webrtc/RTCDataChannel-close.html Outdated Show resolved Hide resolved
webrtc/RTCDataChannel-send-blob-order.html Outdated Show resolved Hide resolved
@jan-ivar jan-ivar merged commit 0c3277d into web-platform-tests:master May 28, 2020
@jan-ivar jan-ivar deleted the bothnegotiated branch May 28, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants