Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unison-ucm: 1.0.M1l-alpha -> 1.0.M1m-alpha #88611

Merged
merged 1 commit into from Nov 27, 2020

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented May 22, 2020

Motivation for this change

See Release notes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@virusdave virusdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@ceedubs
Copy link
Contributor Author

ceedubs commented Oct 8, 2020

What's the best process for getting these unison-ucm changes merged?

@worldofpeace I see that you merged #86150. Any tips?

@SuperSandro2000
Copy link
Member

@ceedubs you can hit me up on IRC next time.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 88611 run on x86_64-linux 1

1 package built:
  • unison-ucm

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 88611 run on x86_64-darwin 1

1 package built:
  • unison-ucm

@SuperSandro2000 SuperSandro2000 merged commit 7843692 into NixOS:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants