Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix secp256k1 broken package #88612

Merged
merged 3 commits into from May 28, 2020
Merged

fix secp256k1 broken package #88612

merged 3 commits into from May 28, 2020

Conversation

a-t-richard
Copy link
Contributor

The way setup_version is checked generated errors. I fixed it via postPatch by using string comparison (don't know if it's optimal).

@ofborg ofborg bot requested a review from chris-martin May 22, 2020 18:02
@a-t-richard
Copy link
Contributor Author

After reflection, I think it's more relevant to add something like:

substituteInPlace setup.py --replace "int(i)" "int(i) if i.isdigit() else 0"

Instead of:

substituteInPlace setup.py --replace "[int(i) for i in setuptools_version.split('.')] < [3, 3]" "setuptools_version < '3.3'"

@FRidh
Copy link
Member

FRidh commented May 23, 2020

Please just patch that nonsense out entirely. Setuptools 3.3 is 6 years old.

@a-t-richard
Copy link
Contributor Author

Well, I can't disagree with that.

chris-martin
chris-martin approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@chris-martin chris-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sed patch seems fragile, but seems harmless enough since the python package hasn't been updated since 2016.

@jonringer jonringer merged commit 847de99 into NixOS:master May 28, 2020
@jonringer
Copy link
Contributor

I squashed the commits for you, but please adhere to CONTRIBUTING.md guidelines about git history.

Also, thanks for opening your first PR against nixpkgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-martin chris-martin chris-martin approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@a-t-richard @FRidh @jonringer @chris-martin @Janik-Haag