Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ledger2beancount: init at 2.1 #88544

Merged
merged 1 commit into from Oct 30, 2020
Merged

ledger2beancount: init at 2.1 #88544

merged 1 commit into from Oct 30, 2020

Conversation

Pablo1107
Copy link
Contributor

Motivation for this change

This PR adds a package for ledger2beancount, a "
Ledger to Beancount text-based converter"

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@balsoft
Copy link
Member

balsoft commented Jul 2, 2020

Have you tested that the binaries work?

@balsoft
Copy link
Member

balsoft commented Jul 2, 2020

Do you really need makeWrapper? Also, why is perl in buildInputs and not nativeBuildInputs ?

@Pablo1107
Copy link
Contributor Author

Do you really need makeWrapper? Also, why is perl in buildInputs and not nativeBuildInputs ?

You're right, I based this on another perl package which include it as a buildInputs and this was before I even knew the difference between nativeBuildInputs and buildInputs.

@balsoft
Copy link
Member

balsoft commented Jul 2, 2020

Wait, you might actually need perl in buildInputs if it's used to set the shebang; After all, it's required to run the script on the host.

@Lassulus
Copy link
Member

needs a rebase

@Pablo1107
Copy link
Contributor Author

@Lassulus @ryan4729 conflicts fixed.

@Lassulus Lassulus merged commit cde8207 into NixOS:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Pablo1107 @balsoft @Lassulus @ryantm