Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add day night plasma wallpapers #88542

Closed
wants to merge 2 commits into from
Closed

Add day night plasma wallpapers #88542

wants to merge 2 commits into from

Conversation

SCOTT-HAMILTON
Copy link
Contributor

@SCOTT-HAMILTON SCOTT-HAMILTON commented May 21, 2020 •
edited

Motivation for this change

In the process of ricing my new kde DE, I wanted a dynamic wallpaper that changes into some night themes when sun wasn't lighting my keyboard anymore.

Things done

Started working on the service and the package. Those must be tested but I don't have any idea to how I oould test those without first having them in the repo, help on that part is required.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented May 22, 2020

Thanks for the PR, Scott.

You can use this module in your configuration.nix with:

{
  imports = [
    ./path/to/day-night-plasma-wallpapers.nix
  ];
}

You'll need to define the package slightly differently, though. In general, I think given the age of the module's software it would be a better fit for NUR: https://github.com/nix-community/nur

@grahamc grahamc closed this May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SCOTT-HAMILTON @grahamc