Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chefdk: init chef-solo at 15.11.3 #88631

Closed
wants to merge 1 commit into from
Closed

chefdk: init chef-solo at 15.11.3 #88631

wants to merge 1 commit into from

Conversation

badmutex
Copy link
Contributor

@badmutex badmutex commented May 22, 2020 •
edited

Motivation for this change

chefdk (via the Chef release) exposes a chef-solo command which was
missing from this derivation.

Things done

Added chef-bin and ran bundle lock --update && bundix

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

chefdk: init chef-solo at 15.11.3
c951be8 
chefdk (via the Chef release) exposes a chef-solo command which was
missing from this derivation.

Added `chef-bin` and ran `bundle lock --update && bundix`
@badmutex
Copy link
Contributor Author

@offlinehacker @nicknovitski fyi

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/296

@badmutex
Copy link
Contributor Author

badmutex commented Nov 1, 2020

closing due to inactivity

@badmutex badmutex closed this Nov 1, 2020
@badmutex badmutex deleted the badi/chefdk branch November 1, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@badmutex @nixos-discourse