Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openldap: fix build on darwin #88634

Merged
merged 1 commit into from May 23, 2020
Merged

openldap: fix build on darwin #88634

merged 1 commit into from May 23, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented May 22, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 22, 2020
@marsam marsam mentioned this pull request May 22, 2020
Merged
10 tasks
@marsam
Copy link
Contributor Author

marsam commented May 23, 2020

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from lovek323 May 23, 2020 00:53
@marsam marsam merged commit adf6f30 into NixOS:master May 23, 2020
@marsam marsam deleted the fix-openldap-darwin branch May 23, 2020 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@marsam