Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] xpra: fix #41106 #85694 #88581

Merged
merged 3 commits into from Jun 18, 2020
Merged

[20.03] xpra: fix #41106 #85694 #88581

merged 3 commits into from Jun 18, 2020

Conversation

bbjubjub2494
Copy link
Member

Motivation for this change

Some longstanding issues that affect Xpra in Markhor have been patched.

#87985 #87982

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbjubjub2494 bbjubjub2494 changed the title [20.03] Backport Xpra fixes [20.03] xpra: fix #41106 #85694 (waiting on #87985) May 22, 2020
@bbjubjub2494 bbjubjub2494 changed the title [20.03] xpra: fix #41106 #85694 (waiting on #87985) [20.03] xpra: fix #41106 #85694 #88035 (waiting on #87985 #88526) May 22, 2020
@roberth roberth added the 8.has: port to stable A PR already has a backport to the stable release. label May 22, 2020
@bbjubjub2494 bbjubjub2494 changed the title [20.03] xpra: fix #41106 #85694 #88035 (waiting on #87985 #88526) [20.03] xpra: fix #41106 #85694 #88035 (waiting on #88526) Jun 3, 2020
@bbjubjub2494
xpra: fix NixOS#85694
cd6ea1d 
(cherry picked from commit 8b92f67)
@bbjubjub2494
xpra: fix NixOS#41106
79ac325 
(cherry picked from commit 4459844)
@bbjubjub2494 bbjubjub2494 changed the title [20.03] xpra: fix #41106 #85694 #88035 (waiting on #88526) [20.03] xpra: fix #41106 #85694 Jun 5, 2020
@bbjubjub2494 bbjubjub2494 marked this pull request as ready for review June 5, 2020 20:07
@bbjubjub2494
Copy link
Member Author

(#88526 won't be strictly a backport so it'll be its own PR)

bbjubjub2494 added a commit to bbjubjub2494/nur-expressions that referenced this pull request Jun 6, 2020
@bbjubjub2494
Switch to NixOS/nixpkgs#88581
ba71711
bbjubjub2494 added a commit to bbjubjub2494/nur-expressions that referenced this pull request Jun 6, 2020
@bbjubjub2494
Switch to NixOS/nixpkgs#88581
80f6483
@worldofpeace worldofpeace merged commit 50fc221 into NixOS:release-20.03 Jun 18, 2020
@bbjubjub2494 bbjubjub2494 deleted the backport_xpra branch March 29, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbjubjub2494 @roberth @worldofpeace