Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sway-contrib: init with grimshot and inactive-windows-transparency #88577

Merged
merged 2 commits into from Jun 14, 2020
Merged

sway-contrib: init with grimshot and inactive-windows-transparency #88577

merged 2 commits into from Jun 14, 2020

Conversation

evils
Copy link
Member

@evils evils commented May 22, 2020 •
edited

Motivation for this change

no one appears to be against to the solution reached in #87979

closes #87831

Things done

add package set pkgs.sway-contrib containing
sway-contrib.grimshot, a screenshot utility
with an alias for pkgs.grimshot as this is a fairly fleshed out tool

sway-contrib.inactive-windows-transparency, a script that makes inactive windows transparent

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • /nix/store/ra8b9q1ihdnp04595ahdl6iczg08drgm-grimshot-2020-05-08 101551232
    • /nix/store/hd48r6ss5lpvgqch663z1alnbf6s4p72-python3.7-sway-inactive-windows-transparency-1.4 107722384
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notes

grimshot may get a rotated screen wrong due to bugs in dependencies that have been fixed upstream
inactive-windows-transparency leaves the last active window on a secondary screen active swaywm/sway#5372

@evils evils mentioned this pull request May 22, 2020
Closed
10 tasks
@evils evils mentioned this pull request Jun 1, 2020
Closed
primeos
primeos requested changes Jun 5, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few TODOs.

Regarding #87979 (comment): Yes, unfortunately (in this case) mentioning an issue in a PR doesn't generate any notifications.

pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
pkgs/applications/window-managers/sway/contrib.nix Outdated Show resolved Hide resolved
pkgs/applications/window-managers/sway/contrib.nix Outdated Show resolved Hide resolved
pkgs/applications/window-managers/sway/contrib.nix Show resolved Hide resolved
pkgs/applications/window-managers/sway/contrib.nix Show resolved Hide resolved
@evils evils force-pushed the sway-contrib branch 4 times, most recently from 601bd14 to 491bd89 Compare June 7, 2020 02:36
primeos
primeos approved these changes Jun 7, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now and works as expected. @Mic92 feel free to merge if you want. Alternatively I'll merge it tomorrow if no one has any complaints until then.

Mic92
Mic92 reviewed Jun 8, 2020
View reviewed changes
Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but looks good to me if those last issues are fixed.

@evils evils force-pushed the sway-contrib branch 2 times, most recently from 52a2191 to d904f54 Compare June 8, 2020 10:44
@evils
Copy link
Member Author

evils commented Jun 10, 2020

i think this is ready to merge

Ma27
Ma27 approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Successfully tested this locally.

I left two minor comments, but those are definitely not supposed to keep this PR from getting merged :)

pkgs/applications/window-managers/sway/contrib.nix Show resolved Hide resolved
pkgs/applications/window-managers/sway/contrib.nix Show resolved Hide resolved
@Ma27 Ma27 merged commit baa980c into NixOS:master Jun 14, 2020
@evils evils deleted the sway-contrib branch June 15, 2020 02:06
@primeos primeos mentioned this pull request Jun 15, 2020
Open
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@Ma27 Ma27 Ma27 approved these changes

@primeos primeos primeos approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@evils @Mic92 @Ma27 @primeos