Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metasploit: 5.0.74 -> 5.0.90 #88564

Merged
merged 2 commits into from May 22, 2020
Merged

metasploit: 5.0.74 -> 5.0.90 #88564

merged 2 commits into from May 22, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented May 22, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
Copy link
Contributor Author

zowoq commented May 22, 2020

The editorconfig failure is for the generated gemset.nix file which needs to be resolved (by ignoring the error) for all of the gemset.nix files. #88431

I don't think it blocks this PR.

@Mic92
Copy link
Member

Mic92 commented May 22, 2020

Result of nixpkgs-review pr 88564 1

1 package built:
- metasploit

1 similar comment
@Mic92
Copy link
Member

Mic92 commented May 22, 2020

Result of nixpkgs-review pr 88564 1

1 package built:
- metasploit

@Mic92 Mic92 merged commit e21c3fa into NixOS:master May 22, 2020
@zowoq zowoq deleted the metasploit branch May 22, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants