Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split tests may cause new failure if you insert new tests instead of append to the end #23738

Open
masayuki-nakano opened this issue May 22, 2020 · 0 comments
Labels

Comments

@masayuki-nakano
Copy link
Contributor

When I try to insert new tests into editing/data/delete.js and editing/data/forwarddelete.js, I see new error because of dependency between subtests. For example,

["foo<div><ol><li>[]bar</ol></div>",
    [["defaultparagraphseparator","p"],["delete",""]],
    "foo<div><p>[]bar</p></div>",
    [true,true],
    {"defaultparagraphseparator":[false,false,"div",false,false,"p"],"delete":[false,false,"",false,false,""]}],
["foo<dl><dt>[]bar<dd>baz</dl>",
    [["defaultparagraphseparator","div"],["delete",""]],
    "foo<div>[]bar</div><dl><dd>baz</dd></dl>",
    [true,true],
    {"defaultparagraphseparator":[false,false,"p",false,false,"div"],"delete":[false,false,"",false,false,""]}],

https://searchfox.org/mozilla-central/rev/df4c90d4b8c92c99f76334acfe4813c573c12661/testing/web-platform/tests/editing/data/delete.js#728-737
The latter test checks defaultparagraphseparator command value before running its test. However, that depends on the previous test result. Therefore, if the latter becomes first test of a subtest, it always fails.

The reason why I want to insert instead of append new tests is, the new tests are variant of existing tests. Therefore, for making their expected result consistent, appending new tests have 2 demerits, one is it's harder to check whether there is what you want to add new tests, the other is that it makes taking more time to maintain behavior/spec changes.

@johanneswilm, @zcorpan WDYT? (FYI: split by #11436)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants