Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing device definitions by path #162

Merged
merged 3 commits into from
Jul 28, 2020

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Jun 6, 2020

Thus, facilitating external devices development.

See my mobile-nixos-extra-devices for an example usage.

NOTE: This is not intended to create a rift where users need to make their devices external to this repository. Oh no, this is only intended to allow working with what shouldn't be in this repo. If you look at my example repo, this is used for a pinebook pro, which is definitely not a mobile device for this repo :).


This also fixes a small oversight in the u-boot system, where an option that should have been made optional was mandatory.


TODO

  • Fix bin/menuconfig into better supporting devices by path.

Sorry, something went wrong.

@samueldr samueldr added the 4. type: enhancement New feature or request label Jun 6, 2020
@samueldr samueldr marked this pull request as draft June 6, 2020 19:17
@samueldr samueldr force-pushed the feature/external-devices branch from feb1f4a to 77d07ae Compare June 8, 2020 07:34
@samueldr samueldr force-pushed the feature/external-devices branch from 77d07ae to d888b7b Compare July 26, 2020 02:35
samueldr added 3 commits July 27, 2020 23:26

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This allows external device definitions to be used.
@samueldr samueldr force-pushed the feature/external-devices branch from d888b7b to 8711126 Compare July 28, 2020 04:05
@samueldr samueldr marked this pull request as ready for review July 28, 2020 04:05
@samueldr samueldr merged commit bed63b6 into mobile-nixos:master Jul 28, 2020
@samueldr samueldr deleted the feature/external-devices branch July 28, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. type: enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

1 participant