Allow passing device definitions by path #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueldr
force-pushed
the
feature/external-devices
branch
from
feb1f4a
to
77d07ae
Compare
samueldr
force-pushed
the
feature/external-devices
branch
from
77d07ae
to
d888b7b
Compare
Optional through a default.
This allows external device definitions to be used.
samueldr
force-pushed
the
feature/external-devices
branch
from
d888b7b
to
8711126
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus, facilitating external devices development.
See my mobile-nixos-extra-devices for an example usage.
NOTE: This is not intended to create a rift where users need to make their devices external to this repository. Oh no, this is only intended to allow working with what shouldn't be in this repo. If you look at my example repo, this is used for a pinebook pro, which is definitely not a mobile device for this repo :).
This also fixes a small oversight in the u-boot system, where an option that should have been made optional was mandatory.
TODO
bin/menuconfiginto better supporting devices by path.