Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust-analyzer: 2020-04-20 -> 2020-06-01 and fix build of vscode extension #89649

Merged
merged 4 commits into from Jun 8, 2020
Merged

rust-analyzer: 2020-04-20 -> 2020-06-01 and fix build of vscode extension #89649

merged 4 commits into from Jun 8, 2020

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Jun 6, 2020

Motivation for this change

Bump version.
Also fix build of vscode extension (fix #89286).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@oxalica oxalica requested a review from jonringer as a code owner June 6, 2020 13:47
@oxalica oxalica mentioned this pull request Jun 6, 2020
Closed
10 tasks
@poscat0x04
Copy link
Contributor

poscat0x04 commented Jun 8, 2020 •
edited

Can we get this merged? This extension has been broken for a week now.
cc @jonringer

@Mic92 Mic92 merged commit d903f11 into NixOS:master Jun 8, 2020
@veprbl veprbl mentioned this pull request Jun 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblasc lblasc lblasc approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vscode-extensions.matklad.rust-analyzer broken on master
4 participants
@oxalica @poscat0x04 @lblasc @Mic92