chromium: add rtc_use_pipewire #89565
Conversation
This provides the browser flag #enable-webrtc-pipewire-capturer, which adds support for screensharing on Wayland via xdg-desktop-portal. The browser flag is disabled by default until a user enables it. At least one other major distribution (Arch) enables this compile time option, and so I believe it should be safe to enable by default. This is also needed to support xdg-desktop-portal-wlr which was added in NixOS#83485.
jsravn
force-pushed
the
enable-chromium-rtc-use-pipewire
branch
from
df9cd63
to
fae468b
Compare
|
As mentioned in #89528 (comment), building takes a while, so we don't know yet if that's all necessary to get it working ;-) |
| @@ -17,6 +17,7 @@ | |||
| , protobuf, speechd, libXdamage, cups | |||
| , ffmpeg, libxslt, libxml2, at-spi2-core | |||
| , jre | |||
| , pipewire_0_2 | |||
There was a problem hiding this comment.
Haven't yet built this, but are you sure this is pipewire_0_2 for all three channels?
I ran into some version incompatibility warnings when running pipewire 0.3 and google-chrome-stable (so I'd expect chrome to be built with pipewire_0_2, but beta and dev might use pipewire…
There was a problem hiding this comment.
We can't really check with chromiumBeta and chromiumDev, as they're broken currently on master, too: #89615
There was a problem hiding this comment.
Yes I'm fairly certain it uses pipewire_0_2. Other distros which enable this all build against pipewire 0.2 and from the chromium source it doesn't look like they've updated for 0.3.
There was a problem hiding this comment.
An easy way to test is to add the pipewire 0.3 runtime dependency to the binary packages and see if it can use it (when I try, it fails - it only works with pipewire 0.2).
|
@flokli without 1535270 the webrtc pipewire flag does not appear. It seems that pipewire needs to be in the chromium library path for this flag to be made available (it's the same on Arch - without libpipewire02 on the global lib path, it won't work - see https://www.archlinux.org/packages/extra/x86_64/chromium/). |
|
Yeah, brainfart here, sorry. If chromium is trying to dlopen libpipewire02, it should be exactly as you wrote.
|
This provides the browser flag #enable-webrtc-pipewire-capturer, which
adds support for screensharing on Wayland via xdg-desktop-portal.
The browser flag is disabled by default until a user enables it. At
least one other major distribution (Arch) enables this compile time
option, and so I believe it should be safe to enable by default.
This is also needed to support xdg-desktop-portal-wlr which was added in
#83485.
Motivation for this change
Fix #89528.
Related to #83485.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)