vimPlugins.nvim-typescript: Init at 2020-06-06 #89553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Jun 17, 2020
| ) {}); | ||
| in | ||
| super.nvim-typescript.overrideAttrs(old: { | ||
| buildInputs = [ nodejs ]; |
There was a problem hiding this comment.
this probably isn't needed, as it won't be available at runtime
Suggested change
| buildInputs = [ nodejs ]; |
There was a problem hiding this comment.
It needs nodejs to run npm run build though
There was a problem hiding this comment.
then it should in nativeBuildInputs :)
jonringer
reviewed
Jun 17, 2020
Comment on lines
+716
to
+731
| nvim-typescript-deps = (callPackage ( | ||
| runCommand "nvim-typescript-rplugin.nix" { | ||
| buildInputs = [ nodePackages.node2nix ]; | ||
| } '' | ||
| mkdir -p $out | ||
| cd ${super.nvim-typescript.src}/rplugin/node/nvim_typescript | ||
| node2nix --input package.json \ | ||
| --lock package-lock.json \ | ||
| --include-peer-dependencies \ | ||
| --nodejs-10 \ | ||
| --development \ | ||
| --output $out/node-packages.nix \ | ||
| --node-env $out/node-env.nix \ | ||
| --composition $out/default.nix | ||
| '' | ||
| ) {}); |
There was a problem hiding this comment.
this should fix your evaluation error
Suggested change
| nvim-typescript-deps = (callPackage ( | |
| runCommand "nvim-typescript-rplugin.nix" { | |
| buildInputs = [ nodePackages.node2nix ]; | |
| } '' | |
| mkdir -p $out | |
| cd ${super.nvim-typescript.src}/rplugin/node/nvim_typescript | |
| node2nix --input package.json \ | |
| --lock package-lock.json \ | |
| --include-peer-dependencies \ | |
| --nodejs-10 \ | |
| --development \ | |
| --output $out/node-packages.nix \ | |
| --node-env $out/node-env.nix \ | |
| --composition $out/default.nix | |
| '' | |
| ) {}); | |
| nvim-typescript-deps = runCommand "nvim-typescript-rplugin.nix" { | |
| buildInputs = [ nodePackages.node2nix ]; | |
| } '' | |
| mkdir -p $out | |
| cd ${super.nvim-typescript.src}/rplugin/node/nvim_typescript | |
| node2nix --input package.json \ | |
| --lock package-lock.json \ | |
| --include-peer-dependencies \ | |
| --nodejs-10 \ | |
| --development \ | |
| --output $out/node-packages.nix \ | |
| --node-env $out/node-env.nix \ | |
| --composition $out/default.nix | |
| ''; |
There was a problem hiding this comment.
actually, now that I look at this again, I'm not sure this is correct either. I'm not familiar with using node within nix to give you affirmative answer.
There was a problem hiding this comment.
No, I think this is not going to work without committing a generated node2nix file.
|
I'll just close this since the approach here won't work. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add https://github.com/mhartington/nvim-typescript vim plugin
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)This is my first nix PR, I only started using it today! I have no idea what I'm doing!
I took the code by @nbardiuk and modified until it worked on my machine.
cc @nbardiuk @lo1tuma