Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freeswitch: Disable advertisement banners #89552

Merged
merged 1 commit into from Jun 6, 2020

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Jun 5, 2020

These are banners about a conference nobody cares about. They just spam
the journal without being interesting to anyone.

Motivation for this change

This is from my journal:

freeswitch[891]: .=======================================================================================================.
freeswitch[891]: |       _                            _    ____ _             ____                                       |
freeswitch[891]: |      / \   _ __  _ __  _   _  __ _| |  / ___| |_   _  ___ / ___|___  _ __                             |
freeswitch[891]: |     / _ \ | '_ \| '_ \| | | |/ _` | | | |   | | | | |/ _ \ |   / _ \| '_ \                            |
freeswitch[891]: |    / ___ \| | | | | | | |_| | (_| | | | |___| | |_| |  __/ |__| (_) | | | |                           |
freeswitch[891]: |   /_/   \_\_| |_|_| |_|\__,_|\__,_|_|  \____|_|\__,_|\___|\____\___/|_| |_|                           |
freeswitch[891]: |                                                                                                       |
freeswitch[891]: |    ____ _____ ____    ____             __                                                             |
freeswitch[891]: |   |  _ \_   _/ ___|  / ___|___  _ __  / _| ___ _ __ ___ _ __   ___ ___                                |
freeswitch[891]: |   | |_) || || |     | |   / _ \| '_ \| |_ / _ \ '__/ _ \ '_ \ / __/ _ \                               |
freeswitch[891]: |   |  _ < | || |___  | |__| (_) | | | |  _|  __/ | |  __/ | | | (_|  __/                               |
freeswitch[891]: |   |_| \_\|_| \____|  \____\___/|_| |_|_|  \___|_|  \___|_| |_|\___\___|                               |
freeswitch[891]: |                                                                                                       |
freeswitch[891]: |     ____ _             ____                                                                           |
freeswitch[891]: |    / ___| |_   _  ___ / ___|___  _ __         ___ ___  _ __ ___                                       |
freeswitch[891]: |   | |   | | | | |/ _ \ |   / _ \| '_ \       / __/ _ \| '_ ` _ \                                      |
freeswitch[891]: |   | |___| | |_| |  __/ |__| (_) | | | |  _  | (_| (_) | | | | | |                                     |
freeswitch[891]: |    \____|_|\__,_|\___|\____\___/|_| |_| (_)  \___\___/|_| |_| |_|                                     |
freeswitch[891]: |                                                                                                       |
freeswitch[891]: .=======================================================================================================.

This also appears every time I run fs_cli.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @misuzu
@GrahamcOfBorg build freeswitch

These are banners about a conference nobody cares about. They just spam
the journal without being interesting to anyone.
@dasJ dasJ requested a review from Lassulus June 5, 2020 17:21
@Lassulus Lassulus merged commit d7e2f2c into NixOS:master Jun 6, 2020
@dasJ dasJ deleted the freeswitch-banners branch June 6, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants