Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dune_2: 2.5.1 -> 2.6.0 #89651

Merged
merged 1 commit into from Jun 8, 2020
Merged

dune_2: 2.5.1 -> 2.6.0 #89651

merged 1 commit into from Jun 8, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jun 6, 2020

Motivation for this change

Changelog: https://github.com/ocaml/dune/releases/tag/2.6.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from vbgl June 6, 2020 14:03
@vbgl
Copy link
Contributor

vbgl commented Jun 7, 2020

@GrahamcOfBorg build beluga dune_2 flow fstar jackline ocamlformat satysfi

@vbgl
Copy link
Contributor

vbgl commented Jun 7, 2020

@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_07.dune-configurator

vbgl
vbgl requested changes Jun 7, 2020
View reviewed changes
Copy link
Contributor

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks ocaml-ng.ocamlPackages_4_07.dune-configurator. Possible fix: set the minimumOCamlVersion attribute of that package to 4.08.

@marsam
Copy link
Contributor Author

marsam commented Jun 7, 2020

I think it's an upstream issue, configurator should compile with 4.07 ocaml/dune#3532.
I'll add minimumOCamlVersion if there is no news from upstream

@marsam
Copy link
Contributor Author

marsam commented Jun 8, 2020

Upstream fixed configurator for OCaml 4.07
@GrahamcOfBorg build flow fstar ocamlformat ocaml-ng.ocamlPackages_4_07.dune-configurator

@ofborg ofborg bot requested a review from vbgl June 8, 2020 00:06
@vbgl vbgl merged commit 657f492 into NixOS:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @vbgl