Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.py4j: fix extension zip to default of tar.gz #89568

Merged
merged 1 commit into from Jun 5, 2020
Merged

pythonPackages.py4j: fix extension zip to default of tar.gz #89568

merged 1 commit into from Jun 5, 2020

Conversation

GTrunSec
Copy link
Contributor

@GTrunSec GTrunSec commented Jun 5, 2020

Motivation for this change

the py4j version of 0.10.9 has been changed extension name to tar.gz
fixes error output

 curl: (22) The requested URL returned error:             
 404                                                      
 error: cannot download py4j-0.10.9.zip from any mirror
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GTrunSec GTrunSec changed the title fix extension zip to default of tar.gz pythonPackages.py4j: fix extension zip to default of tar.gz Jun 5, 2020
@ofborg ofborg bot requested a review from shlevy June 5, 2020 21:35
jonringer
jonringer approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 89568 1

9 packages built: - python27Packages.py4j - python27Packages.pyspark - python27Packages.python-ldap-test - python37Packages.py4j - python37Packages.pyspark - python37Packages.python-ldap-test - python38Packages.py4j - python38Packages.pyspark - python38Packages.python-ldap-test

@jonringer jonringer merged commit f342b66 into NixOS:master Jun 5, 2020
@GTrunSec GTrunSec deleted the py4j branch June 5, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@shlevy shlevy Awaiting requested review from shlevy

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GTrunSec @jonringer