Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the cabal version used for hackage2nix #460

Closed
wants to merge 1 commit into from

Conversation

maralorn
Copy link
Member

@maralorn maralorn commented Jun 5, 2020

This fixes #459 for me and looks like a low hanging fruit.

@peti peti closed this in 2a4560c Jun 7, 2020
@maralorn maralorn deleted the pin-cabal branch June 7, 2020 12:08
Profpatsch pushed a commit to Profpatsch/cabal2nix that referenced this pull request Mar 7, 2022
Some packages (BioHMM-1.2.0) have trailing white-space at the end of
their synopsis. This breaks our description normalizing function, which
checks whether the last character of the description is a dot -- and
strips it if it is. Now, newer versions of Cabal actually strip that
trailing white-space, but since we want to be able to compile against
older Cabals, too, we can't rely on Cabal to do that for us. We'll
rather strip all trailing white-space ourselves.

Fixes NixOS#459.
Closes NixOS#460.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hackage2nix: Regeneration hackage-packages.nix is not reproducible
1 participant