Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rq: fix build on darwin #89527

Merged
merged 1 commit into from Jun 5, 2020
Merged

rq: fix build on darwin #89527

merged 1 commit into from Jun 5, 2020

Conversation

chuwy
Copy link
Contributor

@chuwy chuwy commented Jun 5, 2020 •
edited

Motivation for this change

rq could be built on macOS Mojave. The build is failing with following error:

cargo:warning=libgit2/src/path.h:430:10: fatal error: 'iconv.h' file not found
...
warning: build failed, waiting for other jobs to finish...
error: build failed
builder for '/nix/store/akdda7ya5mysclcrjmgjyscysbx5dp0v-rq-1.0.2.drv' failed with exit code 101
error: build of '/nix/store/akdda7ya5mysclcrjmgjyscysbx5dp0v-rq-1.0.2.drv' failed

Just copied the fix from similar PR: #36179

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 5, 2020
chuwy added a commit to chuwy/rq that referenced this pull request Jun 5, 2020
@chuwy
Add Nix to installation instructions
26198b2 
Not sure how to compare speed and freshness, but IMO nixpkgs is usually faster to update the registry than e.g. brew.

macOS installation doesn't work yet (NixOS/nixpkgs#89527), but should be fine on Linux distros.
@chuwy chuwy mentioned this pull request Jun 5, 2020
Merged
@ofborg ofborg bot requested review from aristidb and Br1ght0ne June 5, 2020 09:22
@marsam
Copy link
Contributor

marsam commented Jun 5, 2020

@GrahamcOfBorg build rq

@marsam marsam merged commit 7f8f722 into NixOS:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristidb aristidb Awaiting requested review from aristidb

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chuwy @marsam @Janik-Haag