Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pycurl: Exclude another flaky test #89544

Merged
merged 1 commit into from Jun 9, 2020
Merged

pycurl: Exclude another flaky test #89544

merged 1 commit into from Jun 9, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Jun 5, 2020

Motivation for this change

Fixes #77304 (comment).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Note I've only tested it on release-20.03. This is the forward-rebase to master of that.

This should be backported to release-20.03 after merge, because currently 20.03 is flaky.

@nh2 nh2 requested a review from jonringer June 5, 2020 13:55
@nh2 nh2 requested a review from FRidh as a code owner June 5, 2020 13:55
@nh2 nh2 self-assigned this Jun 5, 2020
@nh2 nh2 mentioned this pull request Jun 5, 2020
Closed
@florianjacob
Copy link
Contributor

am bitten by this as well 👍 (fourth rebuild did work out)

@maralorn
Copy link
Member

maralorn commented Jun 9, 2020 •
edited

I am affected by this and I know more people who are.
EDIT: This is affecting me on stable since two days ago.

@maralorn
Copy link
Member

maralorn commented Jun 9, 2020

@nh2 do you plan to backport this to 20.03?

@maralorn
Copy link
Member

maralorn commented Jun 9, 2020

Okay, latest 20.03 hydra hydra build succeed again for pycurl.

https://hydra.nixos.org/job/nixos/release-20.03/nixpkgs.python37Packages.pycurl.x86_64-linux

jonringer
jonringer approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

https://github.com/NixOS/nixpkgs/pull/89544
1 package failed to build:
python27Packages.nixpart0

25 packages built:
pyCA python27Packages.blivet python27Packages.koji python27Packages.nixpart python27Packages.osc python27Packages.pycurl python27Packages.pykickstart python27Packages.urlgrabber python27Packages.wfuzz python37Packages.bugwarrior python37Packages.nvchecker python37Packages.osc python37Packages.patator python37Packages.pycurl python37Packages.urlgrabber wfuzz python38Packages.bugwarrior python38Packages.nvchecker python38Packages.osc python38Packages.patator python38Packages.pycurl python38Packages.urlgrabber python38Packages.wfuzz system-config-printer udocker

@jonringer jonringer merged commit 7440f0f into NixOS:master Jun 9, 2020
@nh2
Copy link
Contributor Author

nh2 commented Jun 15, 2020

@nh2 do you plan to backport this to 20.03?

Yes, but first another one: #90481

@nh2 nh2 mentioned this pull request Jun 15, 2020
Merged
10 tasks
@nh2
Copy link
Contributor Author

nh2 commented Jun 15, 2020

20.03 backport PR: #90543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@nh2 nh2

Labels
6.topic: python 6.topic: reproducible builds 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.7 pycurl build failing in latest unstable
4 participants
@nh2 @florianjacob @maralorn @jonringer