Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kmag: init at 19.12.3 #89543

Closed
wants to merge 1 commit into from
Closed

kmag: init at 19.12.3 #89543

wants to merge 1 commit into from

Conversation

SRGOM
Copy link
Member

@SRGOM SRGOM commented Jun 5, 2020

Motivation for this change

Towards #62168

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/176

Thra11
Thra11 reviewed Jun 13, 2020
View reviewed changes
pkgs/applications/kde/kmag.nix
name = "kmag";
nativeBuildInputs = [ extra-cmake-modules ];
buildInputs = [ kdoctools kxmlgui kio ];
meta = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about description = "A screen magnifier for KDE";

ttuegel
ttuegel reviewed Jul 19, 2020
View reviewed changes
pkgs/applications/kde/kmag.nix
buildInputs = [ kdoctools kxmlgui kio ];
meta = {
license = with lib.licenses; [ gpl2 ];
maintainers = with lib.maintainers; [ ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add yourself to maintainers.

@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
@auroraanna
Copy link
Contributor

kmag was already added.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 8, 2022
@auroraanna
Copy link
Contributor

@ttuegel can you please close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel left review comments

@Thra11 Thra11 Thra11 left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: qt/kde 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@SRGOM @nixos-discourse @auroraanna @ttuegel @Thra11 @ryantm @FliegendeWurst