Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildRustPackage: add documentation on how to create cargo.lock patches #89523

Merged
merged 1 commit into from Jun 5, 2020
Merged

buildRustPackage: add documentation on how to create cargo.lock patches #89523

merged 1 commit into from Jun 5, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 5, 2020 •
edited

Motivation for this change

#29981 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from andir as a code owner June 5, 2020 07:12
@Mic92 Mic92 mentioned this pull request Jun 5, 2020
Closed
wamserma
wamserma suggested changes Jun 5, 2020
View reviewed changes
Copy link
Member

@wamserma wamserma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicking. Otherwise LGTM.

doc/languages-frameworks/rust.section.md Outdated Show resolved Hide resolved
@Mic92 Mic92 merged commit 685f06c into NixOS:master Jun 5, 2020
@Mic92 Mic92 deleted the rust-docs branch June 5, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wamserma wamserma wamserma approved these changes

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
6.topic: rust 8.has: documentation 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @wamserma